ywkang/kernbench2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename impl names: add builtin. prefix for clear provenance

Browse Source 
- components.yaml: all builtin impls use builtin.xxx naming
- topology.yaml: all impl references updated to builtin.xxx
- builder.py: hardcoded ucie impl → builtin.ucie
- Tests: all impl string references updated

Convention: builtin.<name> for built-in, custom.<name> for user-defined.
382 tests passing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Yangwook Kang
2026-04-09 00:16:24 -07:00
parent 1d95df4bee
commit 81ce55571d
7 changed files with 87 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kernbench/topology/builder.py
+6 -6
View File
@@ -277,7 +277,7 @@ def _instantiate_io_chiplets(
for phy in inst["ucie"]["phys"]:
phy_id = f"{prefix}.ucie-{phy}"
nodes[phy_id] = Node(
id=phy_id, kind="io_ucie", impl="ucie_v1",
id=phy_id, kind="io_ucie", impl="builtin.ucie",
attrs={"overhead_ns": io_ucie_ns},
pos_mm=(cx, noc_y), label=f"IO UCIe-{phy}",
)
@@ -285,7 +285,7 @@ def _instantiate_io_chiplets(
for ci in range(io_n_conn):
conn_id = f"{phy_id}.conn{ci}"
nodes[conn_id] = Node(
id=conn_id, kind="io_ucie_conn", impl="ucie_v1",
id=conn_id, kind="io_ucie_conn", impl="builtin.ucie",
attrs={"overhead_ns": 0.0},
pos_mm=(cx, noc_y), label=f"IO UCIe-{phy} C{ci}",
)
@@ -379,14 +379,14 @@ def _instantiate_cube(
pid = f"{cp}.ucie-{port}"
lx, ly = local_pos[f"ucie-{port}"]
nodes[pid] = Node(
id=pid, kind="ucie_port", impl="ucie_v1",
id=pid, kind="ucie_port", impl="builtin.ucie",
attrs={"overhead_ns": ucie_ns}, pos_mm=(ox + lx, oy + ly),
label=f"UCIe-{port}",
)
for ci in range(ucie_n_conn):
conn_id = f"{cp}.ucie-{port}.conn{ci}"
nodes[conn_id] = Node(
id=conn_id, kind="ucie_conn", impl="ucie_v1",
id=conn_id, kind="ucie_conn", impl="builtin.ucie",
attrs={"overhead_ns": 0.0},
pos_mm=(ox + lx, oy + ly),
label=f"UCIe-{port} C{ci}",
@@ -937,13 +937,13 @@ def _build_cube_view(spec: dict) -> ViewGraph:
pid = f"ucie-{port}"
lx, ly = local_pos[pid]
nodes[pid] = Node(
id=pid, kind="ucie_port", impl="ucie_v1",
id=pid, kind="ucie_port", impl="builtin.ucie",
attrs={}, pos_mm=(lx, ly), label=f"UCIe-{port}",
)
for ci in range(ucie_n_conn):
conn_id = f"ucie-{port}.conn{ci}"
nodes[conn_id] = Node(
id=conn_id, kind="ucie_conn", impl="ucie_v1",
id=conn_id, kind="ucie_conn", impl="builtin.ucie",
attrs={"overhead_ns": 0.0}, pos_mm=(lx, ly),
label=f"UCIe-{port} C{ci}",
)