From 84abf847c4e8f34a0ace0573a67ed1e0608885b6 Mon Sep 17 00:00:00 2001 From: Mukesh Garg Date: Tue, 28 Jul 2026 21:44:21 -0700 Subject: [PATCH] =?UTF-8?q?analytical-viz:=20default=20intra-cube=20(PE?= =?UTF-8?q?=E2=86=94PE)=20BW=20to=20128=20GB/s?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Was 512 GB/s in the analytical viz MachineParams default. Bringing the default down to 128 GB/s to match what the modelled physical link now represents (parity with inter-cube D2D and topology.yaml). Files touched (all three needed to keep defaults coherent): - model_config.py: MachineParams.bw_intra_gbs = 128.0 (was 512.0) - app.py: sidebar selectbox default index = 0 (128 GB/s) instead of 2 (512) - auto_hardware.py: _HW_KNOB_DEFAULTS + BALANCED + COARSE bw_intra_gbs baselines shifted so cost_score at defaults remains 6.0 and the sensitivity sweep starts from the new baseline. Verified: 24 pytest tests pass. Co-Authored-By: Claude Opus 4.7 --- tests/analytical_visualization/app.py | 2 +- tests/analytical_visualization/auto_hardware.py | 6 +++--- tests/analytical_visualization/model_config.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/analytical_visualization/app.py b/tests/analytical_visualization/app.py index 0285b02..645c11d 100644 --- a/tests/analytical_visualization/app.py +++ b/tests/analytical_visualization/app.py @@ -374,7 +374,7 @@ with st.sidebar.expander("Hardware", expanded=False): bw_intra = st.selectbox( "intra-cube GB/s", [128.0, 256.0, 512.0, 1024.0, 2048.0, 4096.0], - index=2, key="bw_intra", + index=0, key="bw_intra", ) bw_inter = st.selectbox( "inter-cube GB/s", diff --git a/tests/analytical_visualization/auto_hardware.py b/tests/analytical_visualization/auto_hardware.py index 219e36c..4f15b96 100644 --- a/tests/analytical_visualization/auto_hardware.py +++ b/tests/analytical_visualization/auto_hardware.py @@ -38,7 +38,7 @@ _HW_KNOB_DEFAULTS = { "pe_hbm_gb": 6.0, "bw_hbm_gbs": 256.0, "peak_tflops_f16": 8.0, - "bw_intra_gbs": 512.0, + "bw_intra_gbs": 128.0, "bw_inter_gbs": 128.0, "bw_intersip_gbs": 50.0, } @@ -47,7 +47,7 @@ _HW_VALUES_BALANCED = { "pe_hbm_gb": [6.0, 12.0], "bw_hbm_gbs": [256.0, 512.0], "peak_tflops_f16": [8.0, 16.0], - "bw_intra_gbs": [512.0, 1024.0], + "bw_intra_gbs": [128.0, 256.0], "bw_inter_gbs": [128.0, 256.0], "bw_intersip_gbs": [50.0, 100.0], } @@ -56,7 +56,7 @@ _HW_VALUES_COARSE = { "pe_hbm_gb": [6.0, 12.0, 24.0], "bw_hbm_gbs": [256.0, 512.0, 1024.0], "peak_tflops_f16": [8.0, 16.0, 32.0], - "bw_intra_gbs": [512.0, 1024.0, 2048.0], + "bw_intra_gbs": [128.0, 256.0, 512.0], "bw_inter_gbs": [128.0, 256.0, 512.0], "bw_intersip_gbs": [50.0, 100.0, 200.0], } diff --git a/tests/analytical_visualization/model_config.py b/tests/analytical_visualization/model_config.py index 3bb7df5..8f66d37 100644 --- a/tests/analytical_visualization/model_config.py +++ b/tests/analytical_visualization/model_config.py @@ -215,7 +215,7 @@ class MachineParams: # HBM per-PE bandwidth (GB/s). bw_hbm_gbs: float = 256.0 # Intra-cube PE↔PE link BW (GB/s). - bw_intra_gbs: float = 512.0 + bw_intra_gbs: float = 128.0 # Inter-cube (UCIe D2D) BW (GB/s). bw_inter_gbs: float = 128.0 # Inter-SIP (C2C / RDMA) BW (GB/s).