687c98086d
Filename + lifecycle:
- ADR rename to ADR-NNNN-<cat>-title.md with 8 3-letter category prefixes
(dev / mem / lat / prog / algo / par / api / ver). Numbers stay immutable.
- ADR Lifecycle split into 3 folders, documented in CLAUDE.md Part 2:
docs/adr/ (Accepted), docs/adr-proposed/ (Proposed/Stub/Draft),
docs/adr-history/ (Superseded/Merged). Status field gains "Draft" for
retroactive docs pending verification.
Merges (one ADR per topic, no change-history annotations):
- ADR-0017 absorbs ADR-0019 (Cube NOC + per-PE HBM connectivity, 10 D-items)
- ADR-0014 absorbs ADR-0021 (PE pipeline execution model, 8 D-items incl.
TileToken self-routing and multi-op composite epilogue scope)
- ADR-0023 absorbs docs/ipcq-dma-codesign-hw.md as new "HW Realization
Notes (Informative)" section (D16-D23 + Open HW Questions). codesign-hw.md
deleted; ADR-0019/0021 moved to adr-history with one-line stub status
Retroactive documentation (G4 closures, code-verified):
- ADR-0037 forwarding component (TransitComponent: first-flit overhead,
serial worker, path-based routing, single impl/multiple names)
- ADR-0036 IO_CPU component (target_start_ns global barrier stamping,
per-cube fan-out, response aggregation)
- ADR-0035 M_CPU & M_CPU.DMA component (3 fan-out paths, DMA Resources,
target_start_ns passthrough)
- ADR-0034 HBM controller internal design (per-PC state, address-based
selection, flit-aware per-flit commit, async finalize, command-only
fallback path)
Content updates:
- ADR-0010 expanded to full CLI surface (run/probe/web), retitled
"Command Line Interface and Execution Semantics"
- ADR-0007 D2 rewritten to current state; ADR-0015 supersession notes pruned
- ADR-0005 wrapped in Decision header with D1-D5; ADR-0022 metadata
block replaced with standard Status header
- ADR-0024 trimmed to rank=SIP launcher essentials (D1-D4);
ADR-0027 cleaned of supersession history
- ADR-0033 D6 cleanup: address-based PC selection moved out of future-work
(now documented in ADR-0034 D3); related D1/D3 wording realigned
- Cross-references back-filled in 5 ADRs (G3 gaps closed)
Onboarding docs split:
- docs/onboarding/ created
- moved: hw-architecture-overview.md, latency-model.md, di-presentation.md,
ccl-author-guide{,.en}.md
- references updated in README, ADR-0023{,.en}, src/kernbench/ccl/__init__.py
Source / test / yaml: ADR-NNNN cross-references in docstrings and YAML
comments updated after the merges (ADR-0021->0014 D6, ADR-0019->0017 D8).
No behavior change.
Tooling:
- tools/verify_adr_lang_pairs.py + tests/test_verify_adr_lang_pairs.py
(ADR EN/KO pair invariant checker)
- .claude/commands/report.md tracked (/report slash command)
- .gitignore: allow .claude/commands/*.md while keeping settings files ignored
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
86 lines
2.8 KiB
Python
86 lines
2.8 KiB
Python
"""ADR-0027 T1: TP parallel_state (D3).
|
|
|
|
Phase 1: ``kernbench.tp`` module does not exist yet — tests fail at import.
|
|
Phase 2 (D2/D3) lands the package and these pass.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
|
|
def _make_ctx(topology):
|
|
from kernbench.runtime_api.context import RuntimeContext
|
|
from kernbench.runtime_api.types import DeviceSelector
|
|
from kernbench.sim_engine.engine import GraphEngine
|
|
|
|
engine = GraphEngine(topology.topology_obj, enable_data=True)
|
|
return RuntimeContext(
|
|
engine=engine,
|
|
target_device=DeviceSelector("all"),
|
|
correlation_id="test_t1",
|
|
spec=topology.topology_obj.spec,
|
|
)
|
|
|
|
|
|
def test_tp_package_importable():
|
|
"""D2: kernbench.tp must be importable."""
|
|
import kernbench.tp as tp
|
|
assert hasattr(tp, "initialize_model_parallel")
|
|
assert hasattr(tp, "get_tensor_model_parallel_world_size")
|
|
assert hasattr(tp, "get_tensor_model_parallel_rank")
|
|
|
|
|
|
def test_initialize_model_parallel_matches_world_size(topology, tmp_path, monkeypatch):
|
|
"""D3: TP size must equal dist world_size; otherwise NotImplementedError."""
|
|
import kernbench.tp as tp
|
|
|
|
with _make_ctx(topology) as ctx:
|
|
ctx.distributed.init_process_group(backend="ahbm")
|
|
ws = ctx.distributed.get_world_size()
|
|
|
|
tp.initialize_model_parallel(ws)
|
|
assert tp.get_tensor_model_parallel_world_size() == ws
|
|
|
|
|
|
def test_initialize_mismatched_ws_raises(topology):
|
|
"""D3: calling with tp_size != world_size raises NotImplementedError."""
|
|
import kernbench.tp as tp
|
|
|
|
with _make_ctx(topology) as ctx:
|
|
ctx.distributed.init_process_group(backend="ahbm")
|
|
ws = ctx.distributed.get_world_size()
|
|
|
|
with pytest.raises(NotImplementedError):
|
|
tp.initialize_model_parallel(ws + 1)
|
|
|
|
|
|
def test_get_tp_rank_is_greenlet_local(topology):
|
|
"""D3: get_tensor_model_parallel_rank returns greenlet-local rank
|
|
(delegates to torch.distributed.get_rank, ADR-0024 D2)."""
|
|
import kernbench.tp as tp
|
|
|
|
with _make_ctx(topology) as ctx:
|
|
ctx.distributed.init_process_group(backend="ahbm")
|
|
ws = ctx.distributed.get_world_size()
|
|
tp.initialize_model_parallel(ws)
|
|
|
|
observed: list[int] = []
|
|
|
|
def _worker(rank: int):
|
|
observed.append(tp.get_tensor_model_parallel_rank())
|
|
|
|
ctx.multiprocessing.spawn(_worker, args=(), nprocs=ws)
|
|
|
|
assert sorted(observed) == list(range(ws))
|
|
|
|
|
|
def test_get_world_size_before_init_raises():
|
|
"""D3: uninitialised TP group → accessing world_size fails informatively."""
|
|
from kernbench.tp import parallel_state
|
|
|
|
# Reset internal state if previous tests (or parallel workers) left it set.
|
|
parallel_state._reset_for_tests()
|
|
|
|
with pytest.raises((RuntimeError, AssertionError, TypeError)):
|
|
_ = parallel_state.get_tensor_model_parallel_world_size() + 0
|