Files
kernbench2/benches/ccl_allreduce.py
T
ywkang 4ba0a83e71 Implement ADR-0024 Phase A: SIP-level TP launcher MVP
Scope (Phase A):
- D1: world_size fallback = SIP count (rank = SIP, TP boundary)
- D9: greenlet-local get_rank + _bind_rank (single-driver fallback = 0)
- D10: torch.ahbm.set_device + torch.accelerator.set_device_index alias
- D11: tensor placement scoped to current-device SIP (post-hoc pe_index
  shift — ADR-0026 replaces with structural coords)
- D12/D13: multi-greenlet run() with simple round-robin scheduler;
  hybrid dispatch (ws == SIP count → multi-greenlet, else legacy
  single-worker for ccl.yaml override compat)
- D7 partial: backend.all_reduce submit + yield + wait via launch()'s
  new _defer_wait flag; parent-less greenlets skip yield
- Relaxed shard-count check (len(shards) > 0 instead of == world_size)
- rank_to_pe = SIP-representative [(r, 0, 0)] when ws <= n_sips

Deferred to Phase B:
- Engine-routed install (D2) — keeps sideband
- install_plan.py module (D6) — keeps install.py
- Epoch barrier (D7 full) — simple yield is sufficient for ring ws=2 mock
- Validator registry (D8)
- Cross-SIP multi-greenlet + real kernel integration — matrix
  ring_default_ws hangs in SimPy drain despite ADR-0025 direction fix;
  marked xfail(run=False) pending Phase B diagnosis (suspected per-rank
  kernel_args / program_id mismatch)

Tests:
- test_ccl_ddp_launcher.py (6 new tests) — D1/D9/D10/D11/D12/D13
- test_ccl_allreduce_matrix.py — ring_default_ws xfail'd, override
  cases (ring_tcm_8 / hbm_8 / sram_8 / multi_cube / mesh_2x2 /
  tree_binary_7) all pass via legacy path

514 tests pass, 1 xfail.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-14 09:00:28 -07:00

177 lines
7.1 KiB
Python

"""CCL all-reduce bench (ADR-0024 Phase A).
Driven entirely by ``ccl.yaml`` + ``topology.yaml``:
- ``defaults.algorithm`` in ``ccl.yaml`` picks which kernel to run.
- ``world_size`` resolution: explicit override in ccl.yaml > defaults >
topology's SIP count. ADR-0024 D1: topology fallback is the SIP count
(each rank = one SIP, TP boundary).
- ``run()`` is hybrid:
- If ``world_size == topology SIP count`` (the intended new path):
spawn one greenlet per rank, bind it via ``dist._bind_rank``, and
each worker calls ``torch.ahbm.set_device(rank)`` + runs its portion
of the collective. Cross-rank IPCQ exchange handles the reduce.
- Legacy path (``world_size > SIP count``, via explicit ccl.yaml
override): single worker at rank 0 with the full tensor distributed
across all participating PEs via ``_derive_dp``. Retained for
backward compatibility with existing kernel / topology tests.
"""
from __future__ import annotations
import numpy as np
from greenlet import greenlet
from kernbench.ccl.install import load_ccl_config, resolve_algorithm_config
from kernbench.policy.placement.dp import DPPolicy
# Default per-rank tile size if ccl.yaml doesn't override it.
DEFAULT_N_ELEM = 32
def _derive_dp(spec: dict, world_size: int) -> DPPolicy:
"""Legacy DPPolicy for world_size > SIP count (rank = flat PE index).
Used only in the ccl.yaml-override path so the existing matrix tests
with explicit world_size (8, 16, 7 etc.) keep working. The new
ADR-0024 TP path (rank = SIP) uses a per-rank DPPolicy inside the
worker instead.
"""
sips = int(spec["system"]["sips"]["count"])
cm = spec["sip"]["cube_mesh"]
pl = spec["cube"]["pe_layout"]
pes_per_cube = int(pl["pe_per_corner"]) * len(pl["corners"])
cubes_per_sip = int(cm["w"]) * int(cm["h"])
total = sips * cubes_per_sip * pes_per_cube
if world_size == total:
return DPPolicy(sip="column_wise", cube="column_wise", pe="column_wise")
if world_size <= pes_per_cube:
return DPPolicy(
sip="replicate", cube="replicate", pe="column_wise",
num_sips=1, num_cubes=1, num_pes=world_size,
)
if world_size <= cubes_per_sip * pes_per_cube:
return DPPolicy(
sip="replicate", cube="column_wise", pe="column_wise",
num_sips=1, num_cubes=world_size // pes_per_cube,
)
return DPPolicy(sip="column_wise", cube="column_wise", pe="column_wise")
def worker(rank: int, world_size: int, torch) -> None:
"""Per-rank worker (new TP path) OR single-worker legacy driver.
Behaviour depends on whether this call originates from the
multi-greenlet launcher (new path) or from the legacy single-call
fallback; distinguished by which ``dp`` layout applies.
"""
cfg = resolve_algorithm_config(load_ccl_config())
algo_name = cfg["algorithm"]
n_elem = int(cfg.get("n_elem", DEFAULT_N_ELEM))
spec = torch.spec or {}
n_sips = int(spec.get("system", {}).get("sips", {}).get("count", 1))
if world_size == n_sips:
# ADR-0024 new path: rank = SIP, worker sees its SIP's
# representative PE via torch.ahbm.set_device.
torch.ahbm.set_device(rank)
dp = DPPolicy(cube="replicate", pe="replicate",
num_cubes=1, num_pes=1)
tensor = torch.zeros(
(1, n_elem), dtype="f16", dp=dp, name=f"ccl_in_r{rank}",
)
# Each rank initialises its tile with (rank + 1); after all_reduce
# every rank sees sum(1..world_size).
init = np.full((1, n_elem), float(rank + 1), dtype=np.float16)
tensor.copy_(torch.from_numpy(init))
torch.distributed.all_reduce(tensor, op="sum")
result = tensor.numpy()
expected = float(sum(range(1, world_size + 1)))
all_ok = bool(np.allclose(result, expected, rtol=1e-1, atol=1e-1))
if rank == 0:
if all_ok:
print(f" {algo_name} (ws={world_size}): {world_size} OK")
else:
print(
f" [FAIL] rank {rank} "
f"(ws={world_size}, algo={algo_name}): "
f"got mean={float(result.reshape(-1).mean()):.3f}, "
f"expected={expected:.3f}"
)
print(
f" {algo_name} (ws={world_size}): "
f"0 OK / {world_size} FAIL"
)
return
# Legacy path: world_size overridden via ccl.yaml to exceed SIP count.
# Single-worker at rank 0; whole tensor distributed across all
# participating PEs using the derived DPPolicy. Matches pre-ADR-0024
# behaviour.
dp = _derive_dp(spec, world_size)
tensor = torch.zeros(
(1, world_size * n_elem), dtype="f16", dp=dp, name="ccl_in",
)
init = np.zeros((1, world_size * n_elem), dtype=np.float16)
for r in range(world_size):
init[0, r * n_elem : (r + 1) * n_elem] = float(r + 1)
tensor.copy_(torch.from_numpy(init))
torch.distributed.all_reduce(tensor, op="sum")
result = tensor.numpy()
expected = float(sum(range(1, world_size + 1)))
all_ok = bool(np.allclose(result, expected, rtol=1e-1, atol=1e-1))
if rank == 0:
if all_ok:
print(f" {algo_name} (ws={world_size}): {world_size} OK")
else:
flat = result.reshape(-1)
n_fail = 0
for r in range(world_size):
slice_r = flat[r * n_elem : (r + 1) * n_elem]
if not np.allclose(slice_r, expected, rtol=1e-1, atol=1e-1):
n_fail += 1
if n_fail <= 5:
print(
f" [FAIL] rank {r} "
f"(ws={world_size}, algo={algo_name}): "
f"got mean={float(slice_r.mean()):.3f}, "
f"expected={expected:.3f}"
)
print(
f" {algo_name} (ws={world_size}): "
f"{world_size - n_fail} OK / {n_fail} FAIL"
)
def run(torch) -> None:
"""CLI entry — dispatch to multi-greenlet path when ws == SIP count,
else fall back to single-worker legacy path for ccl.yaml override compat.
"""
dist = torch.distributed
dist.init_process_group(backend="ahbm")
world_size = dist.get_world_size()
spec = torch.spec or {}
n_sips = int(spec.get("system", {}).get("sips", {}).get("count", 1))
if world_size == n_sips:
# ADR-0024 D12/D13: one greenlet per rank, simple round-robin.
gs: list[greenlet] = []
for rank in range(world_size):
def _entry(r: int = rank) -> None:
worker(r, world_size, torch)
g = greenlet(_entry)
dist._bind_rank(g, rank)
gs.append(g)
while True:
alive = [g for g in gs if not g.dead]
if not alive:
break
for g in alive:
if not g.dead:
g.switch()
else:
# Legacy single-worker path (ccl.yaml world_size override).
worker(rank=dist.get_rank(), world_size=world_size, torch=torch)